SAI LPO attributes #2178
Merged
SAI LPO attributes #2178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullaraogunda
force-pushed
the
sai_lpo_attributes
branch
from
5d8e6ef to
617a6e0
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kcudnik
approved these changes
Jun 18, 2025
doc/SAI_LPO_Attributes.md
Outdated
| * @default empty | ||
| */ | ||
| SAI_PORT_SERDES_ATTR_REACH_MODE, | ||
|
|
There was a problem hiding this comment.
please check if this attribute is a standard one, defined in the spec and can be beneficial for all vendors. If it is vendor-specific please consider using the SAI "custom" infrastructure (#2122)
harshitgulati18
approved these changes
Jun 26, 2025
|
@eddyk-nvidia, @prgeor - could you please complete the review on this? |
prgeor
reviewed
Aug 25, 2025
inc/saiport.h
Outdated
| * @flags CREATE_AND_SET | ||
| * @default empty | ||
| */ | ||
| SAI_PORT_SERDES_ATTR_REACH_MODE, |
There was a problem hiding this comment.
@pullaraogunda can we move this to custom attribute since this is not applicable for all vendors ?
SAI_PORT_SERDES_ATTR_END,
/** Custom range base value */
SAI_PORT_SERDES_ATTR_CUSTOM_RANGE_START = 0x10000000,
/** End of custom range base */
SAI_PORT_SERDES_ATTR_CUSTOM_RANGE_END
kcudnik
approved these changes
Aug 26, 2025
eddyk-nvidia
approved these changes
Aug 27, 2025
pullaraogunda
force-pushed
the
sai_lpo_attributes
branch
from
d59dfdc to
31dae6b
Compare
prgeor
approved these changes
Sep 4, 2025
|
@tjchadaga @rlhui could you please merge? |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@pullaraogunda - could you please squash your commits? |
Signed-off-by: pullarao <[email protected]>
pullaraogunda
force-pushed
the
sai_lpo_attributes
branch
from
31dae6b to
2f9ad24
Compare
@tjchadaga Done |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
prgeor
pushed a commit
to prgeor/SAI
that referenced
this pull request
Sep 11, 2025
Signed-off-by: pullarao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SAI port serdes attributes support for Linear Pluggable Optics (LPO)